fix(js): resolve catalog references in pruned package.json output#35805
Open
polygraph-snapshot-app[bot] wants to merge 1 commit into
Open
fix(js): resolve catalog references in pruned package.json output#35805polygraph-snapshot-app[bot] wants to merge 1 commit into
polygraph-snapshot-app[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 684a349
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using the
@nx/js:prune-lockfileexecutor in a workspace that usescatalog:references (pnpm or yarn), the emitteddist/package.jsonstill contains the rawcatalog:specifiers:{ "dependencies": { "@nestjs/common": "catalog:", "zod": "catalog:" } }The emitted
dist/pnpm-lock.yamlcorrectly contains resolved versions (e.g.^11.0.0), because the lockfile path already resolves catalog references internally viagetCatalogManager().resolveCatalogReference().The mismatch causes
pnpm install --frozen-lockfileto fail withERR_PNPM_OUTDATED_LOCKFILE:Expected Behavior
The emitted
dist/package.jsonhascatalog:references resolved to real version strings, matching what the pruned lockfile already contains, sopnpm install --frozen-lockfilesucceeds.Implementation Details
Adds a pure
resolveCatalogReferences()helper in theprune-lockfileexecutor that runs after the project'spackage.jsonis read and before the lockfile is generated. It uses the existinggetCatalogManager()utility (exposed via@nx/devkit/internal) and resolves catalog references acrossdependencies,optionalDependencies,devDependencies, andpeerDependencies— mirroring howpnpm-parser.tshandles them when producing the lockfile.Related Issue(s)
Fixes #35419
View session information ↗